Style Refactoring - Githubissues

FritzAndFriends / BlazorWebFormsComponents

A collection of Blazor components that emulate the ASP.NET Web Forms controls of the same name

MIT License

426 stars 72 forks source link

Style Refactoring #243

Closed hishamco closed 4 years ago

hishamco commented 4 years ago

This include:

Introduce FontInfo to hold all the font related properties
Organize style related related types
Rename IHasXXXStyle to IXXXStyle
Implement IStyle in Component to avoid implement the interface over and over again

hishamco commented 4 years ago

This is ended up with a Component something similar to WebControl in the ASP.NET WebForms, also we already have DataBoundComponent which make everything is clear and clean, no more IHasStyle anymore because it's built-in in the Component

This PR shows the basic control got cleaner after remove all the IHasStyle properties and CalculatedStyle, I will continue after this to let all the components inherits from Component or DataBoundComponent

hishamco commented 4 years ago

Trying to close and open PR to let CI/CD run the test again, but no luck

hishamco commented 4 years ago

I squash the commit and force push, then the tests pass, @csharpfritz please merge #244 because it might break the build on any PR

csharpfritz commented 4 years ago

I'm not a fan of the renaming of all of the IxxxStyle interfaces without an issue to discuss first.

The changes are valuable, and would like to see the Component class renamed to something a little more descriptive first

csharpfritz commented 4 years ago

This dramatically simplifies the implementation of these common style properties in our controls. Much appreciated!

hishamco commented 4 years ago

This dramatically simplifies the implementation of these common style properties in our controls.

Yes, it's