search

FritzAndFriends / BlazorWebFormsComponents

A collection of Blazor components that emulate the ASP.NET Web Forms controls of the same name
MIT License
427 stars 72 forks source link

Attribute Value Conflicts #79

Open csharpfritz opened 4 years ago

csharpfritz commented 4 years ago

from @grleachman in #21

Attribute Value Conflicts

Adding RepeatDirection has caused a conflict with GridLines

There's now an ugly problem where the static enums require the markup to be messy:

Gridlines="Enums.GridLines.Horizontal" RepeatDirection="Enums.RepeatDirection.Horizontal"

This is going to be painful for migration.

hishamco commented 4 years ago

I think the better way to fix this is not using Enums namespace? I can file an issue regarding namespace change suggestion that may make the migration so simple

hishamco commented 4 years ago

Is there a reason to declare enum as abstract class?

csharpfritz commented 4 years ago

There are other features we need to these enums and by taking this approach we get pattern matching to check if the enum is selected

Jeff

On Feb 23, 2020, at 16:07, Hisham Bin Ateya notifications@github.com wrote:

 Is there a reason to declare enum as abstract class?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

hishamco commented 4 years ago

Is this working fine?

Gridlines="GridLines.Horizontal"
RepeatDirection="RepeatDirection.Horizontal"