FritzAndFriends / ResourceManagement

A resource management application originally designed for Sebastian Riding Associates.
MIT License
36 stars 28 forks source link

Add support for fluent assertions #35

Closed SimonGeering closed 5 years ago

SimonGeering commented 5 years ago

@csharpfritz What are your thoughts on adding Fluent Assertions as a dependency with the goal of helping make unit testing easier by increasing readability of assertions? This could form two separate PRs, the first to add the dependency, so making it available for project contributors to utilise. With subsequent PR(s) to switch over the existing unit test code.

csharpfritz commented 5 years ago

This looks like it would be helpful to build our unit tests. Let's move forward with starting to adopt Fluent Assertions

SimonGeering commented 5 years ago

Daniel I have put in a PR #39 which implements this change in all the unit test assertions. I hope I haven't jumped the gun and grabbed an item you were working on! @csharpfritz we may want to allocate issues to people if duplication of PR efforts becomes a problem :-)

marblekirby commented 5 years ago

Great, I had started it, but I didnt get it finished last night. Thanks, I also think we should start assigning issues.