As agreed in #72 this PR will switch all view models to inherit ComponentBase

[SimonGeering]

All ViewModel classes have been changed to inherit ComponentBase.

• Where ViewModels had dependencies injected via constructor injection this has been changed to use property injection with the [Inject] attribute being added to existing properties where possible.
• This has also allowed consolidation of [Parameter] and [CascadingParameter] code which was delegating to ViewModel methods or properties as well as any overrides of ComponentBase
• All code blocks have been removed from all razor files. This should mean that going forward all substantive code logic outside of data and event action bindings can be pulled up into ViewModels, allowing full coverage of scenarios in unit tests.
• Any "cheer graffiti" from the code blocks in the razor files has been moved into the corresponding location in the ViewModel.

To further improve the logical layout of the solution I would propose co-locating the view models in the Pages folder and re-naming them to align with the corresponding razor files so ViewModels/AvailabilityViewModel.cs would become Pages/Availability.ViewModel.cs

This way the code and markup would be right next to each other when being edited without the developer having to hunt in another folder for the corresponding file. I have not included this in the PR as it would be best done in the Git repo to help preserve the git history of the file.

[SimonGeering]

Looks like, for some reason, VS2019 did not clean or re-run tests. Running at the command line shows the failures but not in VS until I re-loaded. May also be a CodeRush issue, either way looking into failing tests and will amend to the PR in a mo.

[SimonGeering]

All tests now running locally

[SimonGeering]

@csharpfritz Looks like this is now failing as the CI/CD pipeline is still using preview 7 SDK as highlighted in the screenshot below:

On a related note, would you be interested in a PR to switch to YAML based multi-stage pipelines?

[csharpfritz]

I've updated the pipeline to use the current SDK

Jeff

On Sun, Aug 18, 2019 at 4:47 PM Simon Geering notifications@github.com wrote:

@csharpfritz https://github.com/csharpfritz Looks like this is now failing as the CI/CD pipeline https://dev.azure.com/FritzAndFriends/Fritz.ResourceManagement/_build/results?buildId=825 is still using preview 7 SDK as highlighted in the screenshot below:

[image: image] https://user-images.githubusercontent.com/25039878/63230220-8f831880-c201-11e9-888e-62fed696f29c.png

On a related note, would you be interested in a PR to switch to YAML based multi-stage pipelines?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FritzAndFriends/ResourceManagement/pull/82?email_source=notifications&email_token=AAATF4LKSG4JW7AZ5WQLJRTQFGYO3A5CNFSM4IMT75TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RH3YI#issuecomment-522354145, or mute the thread https://github.com/notifications/unsubscribe-auth/AAATF4ODLLXDVM65HINN4Q3QFGYO3ANCNFSM4IMT75TA .

[SimonGeering]

It all looks happy now :-)

Let me know re your thoughts on a PR to switch to YAML based multi-stage pipelines?

Thanks, Simon G