FritzAndFriends / StreamDeckToolkit

A .NET Standard library, template, and tools for building extensions to the Elgato Stream Deck
MIT License
164 stars 45 forks source link

Mac Dev needs some love #133

Closed derekforeman closed 5 years ago

derekforeman commented 5 years ago

Describe the bug The default template project does not run on MacOS. The build deploys and the process for the plugin appears to start, but does not execute.

To Reproduce

Start a new plugin project from the template, build and add plugin to stream deck. Execution fails.

Expected behavior The plugin sample from the base template should just run. "F5" ready if you will.

Error Details The plugin fails with an error message from ConnectionManager line 66

throw new ArgumentException($"{nameof(commandLineArgs)} must be the commandline args that the StreamDeck application calls this program with.");

Desktop (please complete the following information):

Additional context In comparison, in windows the template plugin just works. Open the solution/project, start debugging, add the plugin to the stream deck and BOOM!

csharpfritz commented 5 years ago

This looks like the same error I hit on Tuesday night in Windows, and is probably related to the new ConfigBuilder not included in the template.

Jeff

On Wed, Feb 20, 2019 at 11:29 AM derekforeman notifications@github.com wrote:

Describe the bug The default template project does not run on MacOS. The build deploys and the process for the plugin appears to start, but does not execute.

To Reproduce

Start a new plugin project from the template, build and add plugin to stream deck. Execution fails.

Expected behavior The plugin sample from the base template should just run. "F5" ready if you will.

Error Details The plugin fails with an error message from ConnectionManager line 66

throw new ArgumentException($"{nameof(commandLineArgs)} must be the commandline args that the StreamDeck application calls this program with.");

Desktop (please complete the following information):

  • OS: Mac OS
  • Version 10.14.1

Additional context In comparison, in windows the template plugin just works. Open the solution/project, start debugging, add the plugin to the stream deck and BOOM!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FritzAndFriends/StreamDeckToolkit/issues/133, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEy8Xtws0luS1tiWpygvtDNdx4MW2bJks5vPXfsgaJpZM4bFnY3 .

hugodahl commented 5 years ago

I've run into other issues just trying to create and build a project on macOS from the template with just a simple dotnet new, so I took a stab at it tonight and got the template and build script issues resolved. PR forthcoming.

csharpfritz commented 5 years ago

Merged @hugodahl pull request