Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
892 stars 232 forks source link

MCU Toolhead default override X_STOP interferes with Sensorless homing #157

Closed Surion79 closed 1 year ago

Surion79 commented 1 year ago

If sensorless homing is used, the default override for toolhead MCU includes a X_STOP definition, making sensorless x homing not possible. Found out by setting it up and wondering why X was moving with the Stallguardvalue of 255

Frix-x commented 1 year ago

Oh, yeah but this is something I cannot really fix as of now as I can't guess the user setup.

I will fix it by "commenting out" the default overrides for the toolhead and adding some comment on top of the override section. This should helpp and avoid having it automatically enabled and taking over the rest :)

Surion79 commented 1 year ago

I think it is sufficient to comment out the toolhead x endstop section, not whole. Because there are also set ups that don't use x endstop on the toolhead, because they use the pcb on the X/Y joint

Frix-x commented 1 year ago

Done in https://github.com/Frix-x/klippain/commit/eb5083f62286c34aa8f71776a6229a1b04c3a304