Frix-x
commented
1 year ago Hi. Ok so this is not something I started working on, however I want to do it soon. So I'll be happy to accept a PR if you do it 🙂 There is currently already an open PR about a new toolhead board_pins that is using TMC2240. It's not currently merged as I want to properly handle TMCs before doing so, so this is a perfect timing :)
The needs:
- TMC5160 are used when running 48V on A/B so we must be able to change XY (and Z) TMC and not use only the default TMC2209.
- Some new toolhead boards include the TMC2240, so we must be able to change the E TMC.
- TMC2240 are also available as EZdrivers for the new generation of BTT boards that I also plan to support soon. So this is also needed for XYZ.
So basically, this means that we need to choose between approach 1 & 3. As I want to keep things as simple as possible for users, my mind would go to the approach 1 to get everything set in the same way.
However I would add that it's also possible to add an approach 4 that would do the same things as 2, but for XY and Z. We could just duplicate each axis configuration file and add a _TMCxxx at the end. These would just include the correct files as for the E toolhead boards and would avoid the user to have to include 2 files in the printer.cfg. What do you think about this one?
Surion79
M3HNGRY
I open this issue for discussing, how this could be implemented. ( If this comes to an agreement, I offer to create a PR based on the conclusion of this issue)
Current situation: Due to the restrictions on Klipper, the tmc types must be defined directly. Challenge: Apart the "default" 2209, BTT also added a TMC2240 for extruder in their new SB2240 toolhead pcb. The v24 uses TMC5160s. So, different TMCs are coming around.
In general, the configuration betweet stepper and tmc must be separated to be able to be included individually.
Approach 1: (generic, all tmc sections) For each type in X, Y, Z (Z as group, not individual Zs) and E create a dedicated tmc file, which can be included in the printer.cfg individually. Default could be added for X, Y, Z, E x 2209, 2240, 5160 (more can be added easily via a new file)
Approach 2: (only E tmc sections) Instead all types, only E is set up for different TMC types. If a toolhead PCB is used, it would mean that configs e.g. between SB2209 and SB2240 would differ mainly in the part of the tmc config (UART vs SPI). (And these refer to the e_tmc2209.cfg, so it can be included in the board only sections, if no toolhead is used. UART/SPI could also be part of the TMC file.)
This would make the setup easier, since you select the appropriated toolhead pcb, including the version and don't care about the background TMC. e.g. BTT_EBB_SB2240_v1.0.cfg or BTT_EBB_SB2209_v1.0.cfg
Approach 3: (XYZ generic, E based on toolhead/board) This is like a combination of Approach 1 and 2. XYZ are included in the printer cfg and E tmc in board/toolhead config.
@Frix-x which is your prefer approach? Do you have another option?