search

Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
849 stars 221 forks source link

Mismatch in SKR Pico mcu_definition and user_template files #283

Closed NoSoucy10 closed 11 months ago

NoSoucy10 commented 1 year ago

Klippain branch

Version

v4.1.0-0-g5e24c04f and earlier

Describe the bug and expected behavior

There's a mismatch in the extruder motor pins' names between the SKR Pico mcu_definition file and the user_template that's used to generate the mcu.cfg file.

In the definition file, the extruder motor pins are named MCUE0 but in the template it uses MCUE

user_template: image

mcu_definition: image

This causes an error with klipper that can't find the requested pins. image

Renaming them to the correct ones in my mcu.cfg fixed the error.

I suggest renaming the ones in the SKR Pico user_template file to the ones in the mcu_definition file. Sorry for not just making a PR for this simple issue, I don't really know how to participate in a github repo.

Midhy

Additional information and klippy.log

No response

Frix-x commented 1 year ago

Thanks for catching this! I'll fix it in the next release for everyone :)

Surion79 commented 1 year ago

Oooh, nice fiend from me too! I wonder why this never came up on my pico. Need to check after move

Frix-x commented 11 months ago

This should be fixed in 00ec18e8e89e5edb01f8351130d23c03b2f149c5 to be released in the next version :)