Add a check on startup for park position variable

[ksteddom]

Klippain branch

• [X] I confirm using the main branch

Version

v4.1.0-0-g5e24c04f and previous release as well

Describe the bug and expected behavior

I got a movement out of range error the first time I ran my park macro. I looked at the size config file, https://github.com/Frix-x/klippain/blob/main/config/hardware/axis/size/350mm.cfg, and the minimum x and y values are set to 0. In https://github.com/Frix-x/klippain/blob/main/user_templates/variables.cfg the park position is set to variable_park_position_xy: -1, -1. It is an easy fix to either override the minimum x and y values in my overrides.cfg file or change the park position in the variables.cfg file but seems like the repo should have the default changed so there is not a mismatch.

Additional information and klippy.log

klippy.log

[Fragmon]

Thats not a bug. I think the -1, -1 is set to avoid damage. Because of this number you get an error and a" remember" to adjust the values.

[Frix-x]

Hi thanks for raising an issue :) This is indeed not a but ans done on purpose. The variables.cfg file is meant to be customized to your own machine. As every machine is different and because everyone need to park at a different position I prefer to set it to -1, -1 by default in order to produce an error and avoid crashing into something.

But this make me think about an improved mechanism to add for the next version: check on Klippain startup if there is still some unset variables like this park position and warm the user about it directly. This way it will fail before starting a print and can be correct directly.

[ksteddom]

Thank you! I'll update those.

[Surion79]

@Frix-x there is already a pr to check startup variables. I think this is a good place to implement it there