search

Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
849 stars 221 forks source link

Check probe is not working #286

Closed Frix-x closed 1 year ago

Frix-x commented 1 year ago

Klippain branch

Version

v4.1.0

Describe the bug and expected behavior

Apparently the check probe is not checking anything here: https://github.com/Frix-x/klippain/blob/5e24c04f646d6be4d56ad71e96b47fdfb749a910/macros/base/probing/dockable_probe.cfg#L297-L301

I need to validate what is happening exaclty since this macro was written like that 2 years ago (since the 23th November 2021) and everything is working "OK" despite the error (not using params.ACTION)... 🤣

Additional information and klippy.log

This was issued on Discord image

Surion79 commented 1 year ago

So does it miss just the params.ACTION or is it more than just this?

Frix-x commented 1 year ago

Yes it's a quick fix but I want to test and validate that the behavior is not changed (it should not) before merging.

Here is the full conversation from Discord:

image