search

Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
807 stars 215 forks source link

probe_calibrate won't allow for accept #430

Open EricZimmerman opened 6 months ago

EricZimmerman commented 6 months ago

Klippain branch

Version

latest

Describe the bug and expected behavior

I believe this was a problem with klicky at one point too and it's reportedly fixed. With dockable probes, after the first probe, the probe is docked and the tool head comes back to where it was. The adjustment dialog comes up and lets you step up and down, but then you click accept you will get an error message in the console and the new z offset is never made available.

Tl;Dr; it says to do the adjust, you click ACCEPT, and then it complains with the following:

Error: Manual probe failed! Use TESTZ commands to position the nozzle prior to running ACCEPT.

I'm guessing it's the fact that the tool head did not move exactly back where it was, ie x or y is off after the docking.

More info here:

https://github.com/jlas1/Klicky-Probe/issues/8

here was my workaround:

call the ALIASED probe_calibrate which is _BASE_PROBE_CALIBRATE

Now, with this, you will need to

  1. attach probe
  2. go to middle
  3. use the _BASE_PROBE_CALIBRATE macro
  4. printer will probe with probe attached.
  5. MANUALLY remove probe
  6. step down per paper test.
  7. ACCEPT

you now have your probe z offset as a starting point.

Additional information and klippy.log

No response

Surion79 commented 5 months ago

well, how to handle this? Should we start with implementing a verbose block in entry/exit_point to print out the saved coordinates to compare?

Frix-x commented 4 months ago

I just merged a commit (wrongly on the main branch oops, but I'll backport it to develop) about a probe retainer management and this commit added a fix in the probe calibrate macro to save the position. Maybe it will work correctly now. Can you try it and let me know?

Surion79 commented 4 months ago

@EricZimmerman Energy! ;) :D

EricZimmerman commented 4 months ago

Someone else just ran into this recently on discord. When you use probe calibrate it will go to the middle of the bed probe put the probleway and then come back to what seems like where it was, but then once the dialogue comes up for you to step down there is no way for you to then accept it and have it work

The only way I found to make this work was to bypass the overridden macro and call the base macro manually take off the probe and do all the normal stuff and then it works

From my understanding based on what people on discord said this can happen if the tool head does not come back exactly to where it was before it moved

If any of that needs more explanation let me know

Surion79 commented 4 months ago

Someone else just ran into this recently on discord. When you use probe calibrate it will go to the middle of the bed probe put the probleway and then come back to what seems like where it was, but then once the dialogue comes up for you to step down there is no way for you to then accept it and have it work

The only way I found to make this work was to bypass the overridden macro and call the base macro manually take off the probe and do all the normal stuff and then it works

From my understanding based on what people on discord said this can happen if the tool head does not come back exactly to where it was before it moved

If any of that needs more explanation let me know

@EricZimmerman Frix asked that you try it with updated Klippain, since there has been a fix introduced :)

EricZimmerman commented 4 months ago

Ah I have a print going but I can try this later after a pull

EricZimmerman commented 4 months ago

Just did the test. it did NOT work:

Manual probe failed! Use TESTZ commands to position the nozzle prior to running ACCEPT.

after clicking Accept.

Frix-x commented 4 months ago

As discussed on Discord, the fix was only on the main branch but I just backported it to develop also. Please try again with the latest develop and let me know. I have good hope that it will indeed fix it :)

EricZimmerman commented 4 months ago

pulled again from develop, rehomed, centered, attached probe, probe_calibrate, step down, click accept and:

Manual probe failed! Use TESTZ commands to position the nozzle prior to running ACCEPT.

Surion79 commented 4 months ago

@EricZimmerman could you please try with current 4.3 release? Thanks :)

EricZimmerman commented 4 months ago

Has it been updated since release?

Right now I can't test as my printer is being upgraded. Anyone else available?

Surion79 commented 4 months ago

My KlickyPrinter isn't finished yet, so I can't test

Karolas123 commented 1 month ago

Still no work. Can you help me?