Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
769 stars 209 forks source link

FILTER_TIME not set in end_print.cfg #550

Closed qratz closed 1 month ago

qratz commented 2 months ago

Klippain branch

Version

v4.2

Describe the bug and expected behavior

in end_print.cfg a definition for FILTER_TIME is missing when using nevermore filter option:

# If a filter is connected, and used during the print, continue filtering the air
    # for a couple of min before stopping everything
    {% if filter_enabled %}
    {% if filter_name == "nevermore" %}
        START_FILTER
            UPDATE_DELAYED_GCODE ID=_STOP_FILTER_DELAYED DURATION={FILTER_TIME}
        {% elif printer['fan_generic filter'].speed > 0 %}
            {% set FILTER_TIME = params.FILTER_TIME|default(filter_default_time)|int %}
            START_FILTER SPEED=1
            UPDATE_DELAYED_GCODE ID=_STOP_FILTER_DELAYED DURATION={FILTER_TIME}
        {% endif %}
    {% endif %}

Obviously, the call to UPDATE_DELAYED_GCODE ID=_STOP_FILTER_DELAYED DURATION={FILTER_TIME} fails at that point.

Additional information and klippy.log

No response

github-actions[bot] commented 1 month ago

📌 This issue has been marked as stale because it has not had activity in the past 30 days. To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days. Thank you for your contributions!

github-actions[bot] commented 1 month ago

This issue was closed due to inactivity for 14 days. Feel free to reopen it if you think it was an error or if you have new information or progress to share