search

Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
832 stars 219 forks source link

Add the Pause at Layer Functionality for Mainsail #585

Closed Elias23 closed 1 month ago

Elias23 commented 3 months ago

Describe the feature or hardware support you'd like

I'd love to see pause at layer functionality from mainsail to be integrated into klippain. https://github.com/mainsail-crew/mainsail-config#new-feature-pause-at-next-layer-and-pause-at-layer-

Additional context or information

No response

Surion79 commented 3 months ago

what/where exactly should that be implemented? I only see slicer config, where we have already in klippain the set_print_stats macro call. The on layer change is slicer only and the calls for the pause layer are manual gcode calls. We could rename them, but whats the point in that? Please explain a bit more :) Thanks!

Elias23 commented 3 months ago

@Surion79 As I understand it, there is a new option in mainsail to schedule pauses while printing for either the next layer change or at a certain layer. It requires, as far as I know, the slicer config you mentioned plus 2 new macros(SET_PAUSE_NEXT_LAYER and SET_PAUSE_AT_LAYER) and a redefinition of the SET_PRINT_STATS_INFO macro. New GUI option: image Feature in action via overrides: image I assume it would be pretty straight forward to add those macros to klippain, but I might be missing something there.

Surion79 commented 1 month ago

i created a PR to check. i added the functions as described in the linked repo

Elias23 commented 1 month ago

Thank you very much.