Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
832 stars 219 forks source link

SAVE_CONFIG section 'probe' option 'z_offset' conflicts with included value #605

Closed smweil closed 1 month ago

smweil commented 1 month ago

Klippain branch

Version

v4.3.1-14-gf01c4ca1

Describe the bug and expected behavior

When running probe_calibrate I cannot save the changes to my config. I'm overriding a few probe commands, but not z_offset. I'm using a Voron TAP for reference. Thanks!

Additional information and klippy.log

klippy-24.log

EricZimmerman commented 1 month ago

You have to just update the value as an override. Save config does not work with klippain

Surion79 commented 1 month ago

this is a known topic of klipper that using save_config is limited. Due to the nature of the architecture of klippain with many different sets of configuration, makes it impossible to have a correct value being put in printer.cfg.

EricZimmerman commented 1 month ago

Danger clipper supports save config regardless of where the actual value is but I don't know if it's going to actually update your printer.cfg or if it would expect to replace the actual section which wouldn't work very well for how things work

smweil commented 1 month ago

Got it, thank you.