search

Frix-x / klippain

Generic Klipper configuration for 3D printers
GNU General Public License v3.0
850 stars 221 forks source link

Add support for CNC Taps #635

Open jackmoxley opened 1 month ago

jackmoxley commented 1 month ago

Describe the feature or hardware support you'd like

Choatic Labs CNC tap, can't handle the sensitivity the default tap is given in the config. So I would like a specialised config that meets the manufactorers settings. I have added a PR to do just that #632

Additional context or information

The change is taken directly from https://github.com/Chaoticlab/CNC-Tap-for-Voron/blob/master/Manual/CNC%20Tap%20V2.cfg but adjusted to match Klippain setup

Surion79 commented 1 month ago

You can add this in your override. I have also cnc tap of chaoticslab and it works fine with the klippain default settings. We can only provide one set of settings via klippain in the config sections. Individual changes must be put in overrides. I don't see the need to add it.

jackmoxley commented 1 month ago

I can, I was merely adding the manufacturers recommendations. If you don't want it feel free to close.

github-actions[bot] commented 1 day ago

📌 This issue has been marked as stale because it has not had activity in the past 30 days. To keep it open, please respond to this message or add new information. Otherwise, this will be closed in 14 days. Thank you for your contributions!