search

FroMage / jax-doclets

Set of JavaDoc doclets for modern Java annotations APIs
http://www.lunatech-labs.com/open-source/jax-doclets
GNU Lesser General Public License v3.0
26 stars 23 forks source link

Support parameterized types for wrapped values #57

Closed matsli closed 11 years ago

FroMage commented 11 years ago

What's this for?

matsli commented 11 years ago

@returnWrapped with generic types worked fine in 0.10.0 but does not work in master. When using the master version, the type parameter is lost.

Example that worked before:

/* * List all shops. * * @return list of shops * @returnWrapped java.util.List<se.dekra.bb.domain.asset.Shop> /

FroMage commented 11 years ago

Mmm, this is weird, and your fix is weird too. I need to look at this in more details.

matsli commented 11 years ago

Yes, I probably should have raised an issue first. Sorry about that.

FroMage commented 11 years ago

It's OK, I was just wondering what it was about ;)

matsli commented 11 years ago

I did som further research. This is the commit that removed support for generics: db9ca4741ce21e0382e2754a1f4f341b75764742 So generics were previously handled in MethodWriter but that code was removed.

FroMage commented 11 years ago

Damn, looks like you're right. Do you think you can put them back in there?

matsli commented 11 years ago

Yes, if you prefer to have it there. There are some benefits in letting JaxType return something that looks like a real generic type since you then can use the same printing code as for other generic types. However, my fix won't render any type parameters of unknown type and that's a drawback.

matsli commented 11 years ago

I have reverted my fix and backported the old support for generics

FroMage commented 11 years ago

Thanks!