search

FroMage / redpipe

Redpipe Web Framework
Apache License 2.0
70 stars 10 forks source link

Async file handling #34

Open aesteve opened 6 years ago

aesteve commented 6 years ago

When looking at https://github.com/FroMage/redpipe/blob/master/redpipe-engine/src/main/java/net/redpipe/engine/resteasy/FileResource.java#L19

It seems that file handling is directly delegated to RestEasy. Not sure how it's implemented in details, but I'm concerned by the fact it might use blocking IO.

We could consider using Vert.x build-in  FileSystem which exposes some utilities regarding asynchronous IO.

FroMage commented 6 years ago

Yes, very good idea. We'd just need to do the same as RESTEasy does wrt preconditions and caching.