FroMage / redpipe

Redpipe Web Framework
Apache License 2.0
70 stars 10 forks source link

Add server host configuration option #35

Closed aesteve closed 6 years ago

aesteve commented 6 years ago

With Vert.x when creating an http server, there's a host option.

It's not configurable in Redpipe (the port is). I'm a bit afraid it might cause some trouble in some corner cases like cloud deployment.

I think the only times I've been using it, was with Heroku / OpenShift deployment, where you're given a host to listen on, and just can't listen on "localhost" or "0.0.0.0".

Maybe make this a configurable option and expose it through AppGlobals 

FroMage commented 6 years ago

Yeah, you're right it should be configurable. Probably via a config option like the port.

FroMage commented 6 years ago

Fixed.