Make Server class more extensible

FroMage / redpipe

Redpipe Web Framework

Apache License 2.0

70 stars 10 forks source link

Closed abner closed 5 years ago

abner commented 5 years ago

It fixes issue #49.

Added sessionDisabled attribute to allow disable session (for allow create serveless servers);
Changed methods loadFileConfig, loadConfig and setupSwagger visibility to protected;
Added method configureVertxOptions to allow customize VertxOptions used to create the Vertx object;
Added test for sessionDisabled configuration

FroMage commented 5 years ago

LGTM aside from the minor remark. If you can fix it I'll merge this ASAP. Thanks!

abner commented 5 years ago

LGTM aside from the minor remark. If you can fix it I'll merge this ASAP. Thanks!

Ok, i just got it fixed at commit 8a2f8ddd7394ce0e12d6490197c3daa59d240b94

abner commented 5 years ago

Hi. There is an idea when this PR would be accepted?

FroMage commented 5 years ago

Right now. Thanks a lot!