search

FrodeSolheim / fs-uae-launcher

A frontend for the FS-UAE Amiga emulator with support for the OpenRetro online game database.
GNU General Public License v2.0
61 stars 14 forks source link

Icon origin and copyright need clarification for Debian #143

Open glaubitz opened 2 years ago

glaubitz commented 2 years ago

According to the file aboutdialog.py (https://github.com/FrodeSolheim/fs-uae-launcher/blob/1e03a57369041f8667c205c51460b0a5086be7f4/launcher/ui/aboutdialog.py), fs-uae-launcher contains icon files from the oxygen-icon-theme:

FS-UAE includes icons from oxygen-icon-theme, licensed under the terms of the
GNU Lesser General Public License as published by the Free Software
Foundation; either version 3 of the License, or (at your option) any later
version.

However, looking at the icons.json file (https://github.com/FrodeSolheim/fs-uae-launcher/blob/1e03a57369041f8667c205c51460b0a5086be7f4/src/icons/icons.json), there are no icons from this theme used (anymore).

I have also performed a reverse-image search on Google and couldn't find any icons that seem to be coming from the oxygen-icon-theme project (https://github.com/KDE/oxygen-icons).

It would be great if the icon situation could be clarified as the missing attribution for the icons in debian/copyright in the fs-uae-launcher (https://github.com/glaubitz/fs-uae-launcher-debian) package that I have prepared is currently preventing the package from being accepted into Debian unstable.

FrodeSolheim commented 2 years ago

The icons.json file is in the master branch, this is code for the in-development FS-UAE 4 version.

For FS-UAE 3.1.x, the situation should be unchanged from FS-UAE 3.0.x. There are not any new icons.

Regarding the about dialog notice, it is quite possible (and likely as well) that the notice about oxygen theme is outdated (as in, it included at least one icon once, but not anymore).

(For FS-UAE 4 I intend to go through and clean up the icon use thoroughly, making it more clear where each icon is from).

glaubitz commented 2 years ago

Regarding the about dialog notice, it is quite possible (and likely as well) that the notice about oxygen theme is outdated (as in, it included at least one icon once, but not anymore).

The problem is that I haven't found which icon is from the oxygen theme which currently blocks the acceptance of the package in to Debian unstable.

FrodeSolheim commented 2 years ago

I see. I think it is very likely that I just used a single icon or two from Oxygen, and that they have been replaced later (because the color scheme is more saturated and does not fit in with the rest of the icons that well) and that the text simply hasn't been removed.

But I cannot be 100% sure without removing all icons and re-adding icons with known source. Maybe I will. I was planning to do it eventually, so one option is to do that... soon...

ea4eoz commented 2 years ago

The last version of fs-uae-launcher available in Debian (3.0.5+dfsg-1) has stopped working in unstable by the recent upgrade of pyqt5.

Now this issue has become critical for Debian users.

Bishop341-B commented 1 year ago

Any news on this issue?

If there are no more Oxigen icons remaining as it seems by @glaubitz searching, it could be fixed just making a little patch for that version removing that text, please?

Debian users can not use fs-uae-launcher since more than a year because this annoying little thing... :(

glaubitz commented 10 months ago

If anyone can suggest changes to the Debian package that would help sort this copyright issue out, I am more than happy to apply them.

C0RD commented 5 months ago

@glaubitz would it be possible to just drop/replace those unattributed images from the debian-package? (asking for a friend, really ;-)

glaubitz commented 5 months ago

@glaubitz would it be possible to just drop/replace those unattributed images from the debian-package?

Sure. It would be best if the corresponding changes could be all merged upstream and the copyright information updated accordingly.

C0RD commented 5 months ago

If @FrodeSolheim accepts that, looking at the activity of this project lately it seems that it has stalled.

Can you specify the images that need to be replaced?

Bishop341-B commented 5 months ago

I think, is far easier/faster that upstream make a little patch for current version just removing the "FS-UAE includes icons from oxygen-icon-theme, licensed under... [...]" text if there are no more Oxigen icons remaining as it seems.

C0RD commented 5 months ago

I think oxygen isn't the problem here, but the missing attribution/license-statement for the remaining other icons.