Naming of fs-uae-launcher related modules and installing into site-packages

[vext01]

Hi,

I know that it's not advised to install fs-uae-launcher in the system Python tree, but for downstream packaging, it's desirable/necessary.

Whilst packaging for OpenBSD, I've realised that fs-uae installs some modules under somewhat generic names. For example workspace, which could clash with the PyPI package of the same name.

Would it be possible to rename all of the fs-uae-specific modules to begin with fs? Most of them already are prefixed in this way. I think all that remains are:

• arcade
• workspace
• launcher

All three clash with a PyPI package of the same name.

What to you reckon?

[Rhialto]

@vext01 The packaging for NetBSD / pkgsrc simply puts all python files under /usr/pkg/share/fs-uae-launcher/. http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/fs-uae-launcher/

That could also be an option.

[vext01]

I've done something similar to this for now, but it'd be nice if it could all coexist with the regular python stuff.

The only reason it's not recommended to install into the system python is due to these name clashes, right?

On Thu, 23 Jul 2020, 21:41 Rhialto The M., notifications@github.com wrote:

@vext01 https://github.com/vext01 The packaging for NetBSD simply puts all python files under /usr/pkg/share/fs-uae-launcher/. http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/fs-uae-launcher/

That could also be an option.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FrodeSolheim/fs-uae-launcher/issues/85#issuecomment-663221756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAETWG7QSWW23P5DM5D4D6DR5CN7JANCNFSM4PGBXSKQ .

[FrodeSolheim]

You could say that's the only reason yes, but one can also turn the issue on its head and say that there isn't any reason to put the code in site-packages to begin with, since this is not library code intended to be used with other applications. That's how I see it, and why I haven't tried to make the names unique.

I'll keep the ticket open for a bit and give the naming a second round of thinking.

[FrodeSolheim]

I am actually renaming some of the Python packages, but I still do not recommend that these packages are installed into site-packages. These are libraries private to fs-uae-launcher and is not meant to be shared.

For example, the libraries might also be copied into other launcher "products" like fs-fuse-launcher and openretro-launcher. You would then get the same collisions also when the packages are renamed. I am not planning to maintain these packages as general libraries at this point, so the only practical solution is to put them in /usr/lib/fs-uae-launcher or /usr/share/fs-uae-launcher or similar (a directory private to the application).