search

FrodeSolheim / python-lhafile

LHA archive support for Python
BSD 3-Clause "New" or "Revised" License
22 stars 7 forks source link

support for Amiga protection bits and create_system #1

Open sonnenscheinchen opened 10 years ago

FrodeSolheim commented 10 years ago

Hi, sorry for the delay, I'll test and pull this in eventually, I just have been busy. Thanks for contributing back :)

sonnenscheinchen commented 10 years ago

No problem, take your time and keep up your excellent work on fs-uae. :-) Some additional info for the patch: Right now the flags are enabled only if the archive is identified as an amiga archive. Unfortunately there are many older amiga archives with header level 0 out there which can not be identified. In theory we could also get flags from these archives but the result might be wrong. Perhaps you will find a solution. ;) Documentation is here (if you don't already know): http://homepage1.nifty.com/dangan/en/Content/Program/Java/jLHA/Notes/Notes.html

I started making some extract-tools which can automatically create .uaem-files for fs-uae, but there is still a lot of work to do. Maybe some day we see something similar for fs-uae-launcher... :-)

adamel commented 7 years ago

You should rebase your pull request branch to remove the merge commits.

FrodeSolheim commented 3 years ago

This pull request has been open for an embarrassingly long time, will look over again and aim to merge and do a 0.3.0 release.

On another note, I've also set up automated builds via Github actions, so binary wheels for Windows, macOS and Linux are not created (and I upload them to pypi as well).