search

Frodo45127 / rpfm

Rusted PackFile Manager (RPFM) is a... reimplementation in Rust and Qt5 of PackFile Manager (PFM), one of the best modding tools for Total War Games.
MIT License
357 stars 57 forks source link

Adding icon to column headers which contain a description #245

Closed SWarrener closed 1 year ago

SWarrener commented 1 year ago

There are quite a few explanatory comments on various columns headers (the description field in the schema), but unlike in DAVE, there is no easy way to see which column has a description, without hovering over all of them. This change adds a small text box icon to the top of the column so you can easily see where there is a column description.

The icon is freely available to use without attribution. 2023-04-05_19-27

Frodo45127 commented 1 year ago

image Looks good on the light theme, but it's kinda invisible when using the dark theme. Can you add another icon more visible in the dark theme and select one or the other depending on the theme? To know if it's light or dark, you can use if setting_bool("use_dark_theme") {}

Other than that, it looks good.

SWarrener commented 1 year ago

Sorry for the slight delay, was away over Easter. I've updated the pull request with a dark mode icon. The icons will only switch between light and dark when a new packfile is opened, or when the rpfm is restarted.

I did notice a separate issue when making this change, that all tooltips don't appear to be displaying properly in dark mode

Frodo45127 commented 1 year ago

Looks good, so I'll merge it once the tests are done. Regarding the tooltips, I'm aware of that. For what I could investigate, it's a thing only on dark theme on non-windows builds, so it has very low priority right now.