Frodo45127 / rpfm

Rusted PackFile Manager (RPFM) is a... reimplementation in Rust and Qt5 of PackFile Manager (PFM), one of the best modding tools for Total War Games.
MIT License
357 stars 57 forks source link

New version of RPFM CLI is not backward compatible when importing color columns from previous versions of ETW tsv tables #291

Open ilia-sharafutdinov opened 2 months ago

ilia-sharafutdinov commented 2 months ago

For instance, when I'm trying to import factions.tsv created using an older RPFM version export feature, it has separate columns for R, G and B faction colors.

Now, when I'm trying to import that tsv with a new version of RPFM CLI, it isn't capable of handling the old RGB columns and converting them to hex, and all new hex columns are filled with zeros, making all factions black on the minimap.

Frodo45127 commented 2 months ago

Not a bug. Rather, is how schema updates have always worked: if a definition changes (in this case the 3 colour columns have been merged into a single column so rpfm can use the colour selector widget for it), you'll need to re-export the table tsv file in order to get it updated with the new definition. Importing the old one will result in the columns not present on it (in this case, the new colour column) getting a default value (that black colour).

Usually these kind of changes are only done on game updates, or in schema fixes (which is this case). So.... you'll have to re-export the tsv to get it updated with the new column.