FrogSquare / GodotGoogleService

Google play service, login, achievements, leaderboard.
Apache License 2.0
105 stars 14 forks source link

Module doesn't compile and doesn't give any errors #16

Open Yazir opened 5 years ago

Yazir commented 5 years ago

I have set up linux compiling environment which works with kloder's admob module. When I compile this module - the size of custom apk doesn't change and it doesn't appear as singleton after android export.

Export template filesize doesn't change at all when adding or removing the module.

Other modules work fine so I'm not sure where the problem lies - I don't get any errors during compilation.

RameshRavone commented 5 years ago

Oops sorry, I forgot to remkve the return False from can_build function in config.py

On Thu, Apr 11, 2019, 1:38 AM Yazir notifications@github.com wrote:

I have set up linux compiling environment which works with kloder's admob module. When I compile this module - the size of custom apk doesn't change and it doesn't appear as singleton after android export.

Export template filesize doesn't change at all when adding or removing the module.

Other modules work fine so I'm not sure where the problem lies - I don't get any errors during compilation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FrogSquare/GodotGoogleService/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AJp7PtkGF80BnNty4s-4yxPEXawbGhGlks5vfkTKgaJpZM4coJ5C .

Yazir commented 5 years ago

Agh! It gave me a headache yesterday 🤕

After I removed return false i have problem with google-services.json being missing. I've added that to the platform/android/java directory, but now i have this error https://drive.google.com/uc?id=18kWqUcdtxkaE8EyPXXttfTQTG47MHvFf

Now, even after adding your Firebase and SQL modules i get this error https://drive.google.com/uc?id=1TIWwMJlpcxmCWc_BUlYHLY46fQ0xUk77

RameshRavone commented 5 years ago

I think that is not the only error is it, does it has something like

The library com.google.android.gms:play-services-measurement-base is being requested by various other libraries at [ [16.0.5,16.0.5], [16.3.0,16.3.0]], but resolves to 16.3.0. Disable the plugin and check your dependencies tree using . /gradlew :app:dependencies.
Yazir commented 5 years ago

I removed Kloder admob module but the error still persists. Here is the stacktrace from gradle build https://gist.github.com/Yazir/1e9bed076d9c3a0ef0a187d0593d7abb

RameshRavone commented 5 years ago

I have no idea why this is happening, but if I want to guess, this is happening because of method overflow ( > 64k), but GodotGoogleService should not cause this, GodotFirebase will cause it, but only if you are using Firestore.

On Thu, Apr 11, 2019, 6:19 PM Yazir notifications@github.com wrote:

I removed Kloder admob module but the error still persists. Here is the stacktrace from gradle build https://gist.github.com/Yazir/1e9bed076d9c3a0ef0a187d0593d7abb

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FrogSquare/GodotGoogleService/issues/16#issuecomment-482100413, or mute the thread https://github.com/notifications/unsubscribe-auth/AJp7Ppx9OtNC0LhJcLHDHJOXS6QOWbwzks5vfy9OgaJpZM4coJ5C .

Yazir commented 5 years ago

Can I use this module alone without any other dependency modules? If yes - it will be easier to find the cause if I remove the rest.

RameshRavone commented 5 years ago

You can just remove the sql dep methods from frogutils/Utils.java inbetween /**GodotSql**/

On Thu, Apr 11, 2019, 6:38 PM Yazir notifications@github.com wrote:

Can I use this module alone without any other dependency modules? If yes - it will be easier to find the cause if I remove the rest.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FrogSquare/GodotGoogleService/issues/16#issuecomment-482106677, or mute the thread https://github.com/notifications/unsubscribe-auth/AJp7PtaZbD0pckC6TlqeybOvct27Tm44ks5vfzO5gaJpZM4coJ5C .

Yazir commented 5 years ago

Then I can compile this module alone?

RameshRavone commented 5 years ago

Yes, and are you using godot 3.x or 2.x

On Thu, Apr 11, 2019, 6:45 PM Yazir notifications@github.com wrote:

Then I can compile this module alone?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FrogSquare/GodotGoogleService/issues/16#issuecomment-482109207, or mute the thread https://github.com/notifications/unsubscribe-auth/AJp7Pn3PBOhy4kAFHDwcrF2i2Kz50XFZks5vfzVogaJpZM4coJ5C .

Yazir commented 5 years ago

3.1 stable