Frogging-Family / community-patches

A place to find patches that are maintained by the community before myself
100 stars 38 forks source link

wine-tkg-git: Add RtlCreateTimer_fix #122

Closed Iglu47 closed 2 years ago

Iglu47 commented 2 years ago

Mainly affects Guild Wars 2 with Arcdps (no other cases known yet)

Patch fixes probable race condition in Timer Queues, but optional since deltaconnected made his own workaround on the application side by adding extra delays in the timers. But this may not work for some processors, so he expects such cases to be reported and simply increases delays. But as far as I understand, increasing additional delays directly affects performance, so doing this is infinitely undesirable. He said he would probably add a Wine version check and remove delays after resolving https://bugs.winehq.org/show_bug.cgi?id=51683

I've been using this patch since September 2021 in my builds of Wine for everyday use and haven't noticed any issues caused by this patch so far.

Tk-Glitch commented 2 years ago

I'm sure that will make some happy. Thanks Iglu47 ! 🐸 ❤️