Bash 5.2~rc2 breaks the install.sh script

cpw commented 2 years ago

Before reporting an issue, please check for relevant keywords in the issues search bar, including closed issues. The solution to your issue might be there already !

This isn't a bug I expect that linux-tkg can fix - it's an upstream issue with bash 5.2~rc2-2, but I'm posting here because the problem manifests with your install script.

Describe the bug

Which OS do you encounter the bug on? Debian Sid
A clear and concise description of what the bug is. The install script fails with
```
./install.sh: line 304: syntax error near unexpected token `schedtool'
```
Attach the contents of your logs folder by drag & dropping each file into this message.

This is an upstream bash bug! The debian issue is here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018727

I don't know if there's an upstream bash issue yet, but hopefully there will be soon.

My solution is to downgrade bash to 5.1-6.1+b1 from bookworm.

sudo apt install bash/bookworm

I hope this helps someone else if they run into this. It does look like there maybe changes incoming to $() expansion handling in 5.2 bash, that may end up breaking that line however. I can't see much on the bash bugs discussing it.

Tk-Glitch commented 1 year ago

By the way, we are currently working around the bug with https://github.com/Frogging-Family/linux-tkg/commit/de0a0d301e9e084f451dd6cf657ff4c0a5cb7992 on non-pacman distros. Since Arch is still using bash 5.1 the change wasn't ported over to the PKGBUILD.

AdelKS commented 2 weeks ago

Is this still a thing ? Maybe we can revert that workaround

Frogging-Family / linux-tkg

Bash 5.2~rc2 breaks the install.sh script #580