search

Frogging-Family / wine-tkg-git

The wine-tkg build systems, to create custom Wine and Proton builds
888 stars 159 forks source link

[Question] What is the "_staging_upsteamignore" variable for? #1229

Closed Artewar67 closed 1 month ago

Artewar67 commented 2 months ago

When testing some legacy patches I found that the _plain_commit variable does not work as long as _use_staging is true

Going into the PKGBUILD code I saw how this works.

if [ -n "$_plain_version" ]; then
  if [[ "$_LOCAL_PRESET" = valve* ]]; then
    _plain_commit="#branch=$_plain_version"
  elif [ "$_use_staging" = "false" ] || ( [ "$_use_staging" = "true" ] && [ "$_staging_upstreamignore" = "true" ] ); then
    _plain_commit="#commit=$_plain_version"
  fi
fi

What was the _staging_upstreamignore variable for?

whrvt commented 1 month ago

it allows you to set a _plain_commit which is decoupled from this. for example, you want to compile wine master + staging master, but staging hasn't been rebased yet.

Artewar67 commented 1 month ago

I was starting to understand a bit of the logic myself, but thanks for the reply