search

Frojd / wagtail-geo-widget

Wagtail-Geo-Widget is the complete map solution for your Wagtail site.
MIT License
138 stars 37 forks source link

Wagtail 4 #111

Closed katdom13 closed 1 year ago

katdom13 commented 1 year ago

Release notes: https://docs.wagtail.org/en/stable/releases/4.0.html

Tests are OK

Found 14 test(s).
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
..............
----------------------------------------------------------------------
Ran 14 tests in 0.130s

OK
nickmoreton commented 1 year ago

Hey @katdom13 Just one thing I noticed in the docs.

body = StreamField([
        ('map', LeafletBlock()),
    ])

for correctness should be 

body = StreamField([
        ('map', LeafletBlock()),
    ], use_json_field=True)
katdom13 commented 1 year ago

Hi @nickmoreton , I have fixed the doc as here: https://github.com/Frojd/wagtail-geo-widget/pull/111/commits/e360d104d0c8c33f42a07f10204b4919a2c43b62

Thank you for this!

nickmoreton commented 1 year ago

I have fixed the doc as here: e360d10

I think there are a few more that can be updated, not exactly the same as the above. Be good to get them all updated 😄

marteinn commented 1 year ago

Thank you @katdom13 for the fantastic work and @nickmoreton for reviewing. LGTM, merging.