Unforgiven Legendary pistol is absent in part_name_mapping.json

FromDarkHell / BL3SaveEditor

A desktop based save and profile editor for Borderlands 3

GNU General Public License v3.0

227 stars 44 forks source link

Unforgiven Legendary pistol is absent in part_name_mapping.json #15

Open tyukh opened 2 years ago

tyukh commented 2 years ago

Unforgiven Legendary pistol is absent in part_name_mapping.json, so UserFriendlyName failed to be showed right in list. BL3(BOMwdWzeupH42PZLpfXV81Cch17TWnSUVnbNKQ5w2AqIkVzjFR7y) code for check. Item with that code was get "legaly" in game.

tyukh commented 2 years ago

Some addition: there also another items with wrong naming.

Gunerang / Bangerang pair: frendly name Gunerang for both

BJh16CXdo1JlA2PkQmMahezVxJFB+rCPpSSl2GC4GfMCVw==    Gunerang    Balance_PS_TED_Gunerang
BH41QAmTejiYPTns8/PsjemiZFkgtlDZtm1FX6unL6V+A1Y=    Gunerang    Balance_PS_TED_Bangerang

The Lob / Shocker pair: frendly name The Lob for both

BCMZdj2Df2oguigN1Wg9xxG+ZM0EJD94EOQCz/tk31wpRJQ=    The Lob     Balance_SG_Torgue_ETech_TheLob
BP89ziIDszScYGUXHVCApjDbC3J2HK4MOoCGWJszZrwjKOU=    The Lob     Balance_SG_Torgue_ETech_Shocker

FromDarkHell commented 2 years ago

So this is kinda an issue with how I have to determine item names. The title of a gun is mainly determined by the barrel (most cases), but because Gearbox is Gearbox, you've got unique guns (Lob/Shocker, Gunerang/Bangerang) which can share a barrel despite different balances. For now, until I feel a bit more energized with this, I think this is just enough of a niche case for me to not quite feel like fixing it.