search

FromDarkHell / BL3SaveEditor

A desktop based save and profile editor for Borderlands 3
GNU General Public License v3.0
227 stars 44 forks source link

editor crash profile save corruption #9

Closed Eclipse2025 closed 2 years ago

Eclipse2025 commented 2 years ago

so testing on profile save (thanks for reminding about backups!) any edits done on profile save, for weapons level/mayhem mods or unlock room customizations and characters customizations. edit1: also crashes/corrupts for just opening and then saving with no changes made crash the editor during save/save as corrupt the profile.sav can cant reopen with this error. Error parsing save: Index was out of range. Must be non-negative and less than the size of the collection. Parameter name: startIndex

here is debug text: at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource) at System.BitConverter.ToInt32(Byte[] value, Int32 startIndex) at IOTools.IOWrapper.ReadInt32() in J:\Coding Projecties\BL3SaveEditor\IOTools\IOWrapper.cs:line 399 at BL3Tools.BL3Tools.LoadFileFromDisk(String filePath, Platform platform, Boolean bBackup) in J:\Coding Projecties\BL3SaveEditor\BL3Tools\BL3Tools.cs:line 62 at BL3SaveEditor.MainWindow.OpenSave(String filePath, Platform platform) in J:\Coding Projecties\BL3SaveEditor\BL3SaveEditor\MainWindow.xaml.cs:line 337

FromDarkHell commented 2 years ago

Can you send the profile because without it, it does not do much?

FullZetsu commented 2 years ago

profile_broke.zip profile_def.zip Here are my own unbroken and broken profile.sav files.

FromDarkHell commented 2 years ago

Fixed in release 1.1.1.

As an explanation instead of just saying lol fixed bye, @FullZetsu (and I figure @Eclipse2025 too)'s profile contained an item that I can't properly save out after reading it in. Each item has an "inventory key" attached, and for ECHO themes, they don't really have an inventory key attached. So when it would try to save the ECHO theme item, it would just crash because it didn't have the key.

Now instead, it basically "backs up" all items, so if it can't save it (no inventory key), it'll use that backup instead. I was actually already doing this for save games, but not for profiles.

Eclipse2025 commented 2 years ago

Can you send the profile because without it, it does not do much? profile.zip

sorry about that, and yes i see its closed off but still would like to see just what about the profile broke and possibly fix on my end. @FullZetsu thats appreciated, thanks

FromDarkHell commented 2 years ago

sorry about that, and yes i see its closed off but still would like to see just what about the profile broke and possibly fix on my end. @FullZetsu thats appreciated, thanks

It's closed off because I fixed it in 1.1.1. Your profile probably included an item (Bank or Lost Loot) that my editor cannot handle. Now it handles those items a bit more gracefully. Your profile should be fine now, it wasn't a problem on your end at all.

Eclipse2025 commented 2 years ago

sorry about that, and yes i see its closed off but still would like to see just what about the profile broke and possibly fix on my end. @FullZetsu thats appreciated, thanks

It's closed off because I fixed it in 1.1.1. Your profile probably included an item (Bank or Lost Loot) that my editor cannot handle. Now it handles those items a bit more gracefully. Your profile should be fine now, it wasn't a problem on your end at all.

got it thanks. much appreciated, ill dl the update now