Frommi / miniz_oxide

Rust replacement for miniz
MIT License
168 stars 48 forks source link

impl Display for DecompressError #123

Closed Shnatsel closed 1 year ago

Shnatsel commented 1 year ago

I wanted to go ahead and implement #122, but miniz_oxide only has feature flags for alloc and not std, so Display is as far as I could get. This is still much better than nothing.

oyvindln commented 1 year ago

Yeah this was why I didn't add the Error trait right away - wasn't quite sure how it works with no_std etc. I couldn't find any way of adding the Error trait without dragging in std, not sure if that's doable or not. If it's possible to check for if no_std is used one could maybe only add it if std is active as someone requiring no_std is probably less likely to use stuff requiring alloc anyhow.