search

Frommi / miniz_oxide

Rust replacement for miniz
MIT License
168 stars 48 forks source link

`adler` is archived #148

Open smoelius opened 3 months ago

smoelius commented 3 months ago

As of yesterday, it seems: https://github.com/jonas-schievink/adler

EDIT: adler is relied upon here: https://github.com/Frommi/miniz_oxide/blob/79307d7bd6e4aa3e86b30fd225a00ecb412188a4/miniz_oxide/Cargo.toml#L20

oyvindln commented 3 months ago

Hm. I don't know whether this is an issue or not. There aren't really any alternatives atm as simd-adler32 uses unsafe (due to the use of manual SIMD code) hence why it's an optional feature, and the reason we moved to the adler crate from adler32 originally was due to licensing differences. (The adler32 git has it's last update even further back.)

I guess we'd need to fork it or ask if it would be possible to take over the crate or something if an update is be needed. Judging by the benches at the simd-adler32 page it's possible there are some performance improvements that could be done even if explicit SIMD can't be used due to unsafe. (ofc using the simd feature which uses simd-adler32 will speed up things more if that's important, and one is using the zlib wrapper specifically.)

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something as well as I'm basically the sole maintainer currently, not sure if @Frommi is accessible these days.

smoelius commented 3 months ago

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something

FWIW, miniz_oxide appears in my projects' dependency trees under anyhow >> backtrace and gix >> ... >> flate2.

... I'm basically the sole maintainer currently ...

Thank you for that! :pray: