Frommi / miniz_oxide

Rust replacement for miniz
MIT License
168 stars 48 forks source link

Add an optional feature for 1.34.2 backwards compatibility #84

Closed HeroicKatora closed 3 years ago

HeroicKatora commented 4 years ago

The readme states that the crate is compatible with 1.34, however this is no longer true due to relying on extern crate alloc which was stabilized in 1.36. Since alloc is just a subset of std we can restore this compatibility via an optional feature, disabled by default and fully opt-in.

Alternatives

@alexcrichton Would this be fine and compatible with std inclusion, by not activating the feature there?

alexcrichton commented 4 years ago

This should work for libstd, yes, but I'd probably recommend to instead just bump the minimum version.

HeroicKatora commented 4 years ago

We had promised not to do that without a major version. Well, it's been almost a year and there are a few potentially breaking changes in the pipeline anyways. I'll consider this another reason to do it.

oyvindln commented 4 years ago

1.34 is what's in debian stable, so I think it may be reasonable to still be compatible with it, if it can be done without causing other issues.

oyvindln commented 3 years ago

Would people be okay with merging this? I see there is some demand for being able to update.

Alphare commented 3 years ago

I have commented in #90 the reasons why I'm in favor of this PR being merged.