Closed Lokathor closed 3 years ago
Frommi checked their box, so I'll ping everyone else: @arbitrix @ctjhoa @dholbert @dingelish @eminence @FauxFaux @fhanau @golddranks @ignatenkobrain @jonas-schievink @matklad @oyvindln @RReverser @Shnatsel @srijs @vlad20012 @wehlutyk
Signed-off by Yu Ding @dingelish :p
Fine with me. But please add texts of those licenses into the tree.
Ah, can do.
I'm ok too
I agree to adding Zlib and Apache 2.0 licenses
I don't even remember contributing, which probably means that my contribution is too small for you to even ask.
But, yes, please do.
I agree to adding Zlib and Apache 2.0 licenses.
I license past and future contributions under Zlib OR Apache-2.0 or MIT license, allowing licensees to chose any one at their option.
I'm fine with this too
I'm fine with this.
Apologies, there was apparently a copy/paste mixup and @alexcrichton wasn't initially on the list, so you get a ping too.
👍 fine by me
I agree to adding Zlib and Apache 2.0 licenses
I've only contributed one commit which was a 1-character typo-fix, so I'm arguably not really a code contributor. :) But, setting that aside: sure, I'm fine with this license change.
I also agree to adding the licenses.
I agree to adding Zlib and Apache 2.0 licenses
No problem from my side.
I agree to this change of licenses.
I made a gaffe and would like to apologize to everyone.
The PR had been set to affect the miniz_oxide_c_api
. I intended to change things for the miniz_oxide
crate. I was not clear on the repo organization at the time (the intended crate is in a sub-directory), and so I altered the wrong Cargo.toml and added the new licenses all at the repository root.
I have pushed the proper changes so that this PR now applies to just the miniz_oxide
crate.
Since the relicense has been signed off on by everyone who has touched that crate specifically:
Okay, so the remaining two contributors, @arbitrix and @wehlutyk contributed to the C API part only so I think this should be fine to merge, looks like both have not been active lately. (@arbitrix contribution was just removing a line, so I don't know if that is something that counts as needing approval either.)
@oyvindln i resolved the merge conflicts that came up recently. Can you merge and publish yourself? Or do we need to keep waiting for @Frommi ?
I can do that, may wait a bit with publishing unless it's urgent, would like to get #97 in.
Understandable. I'll subscribe to that PR too.
Thanks for getting to this!
I agree to this change of licenses.
Per https://github.com/Frommi/miniz_oxide/issues/66, this adds the
Zlib
license as a possible license for users of the crate. While we're at it, it's probably best to also add theApache-2.0
license as an option.I expect this to be fairly uncontroversial, but this would need sign off from past code contributors (alphabetical order):
If @Frommi is still on board with the idea then we can start pinging the rest of people.