search

Frommi / miniz_oxide

Rust replacement for miniz
MIT License
168 stars 48 forks source link

Automatic alloc detection #95

Closed Plecra closed 3 years ago

Plecra commented 3 years ago

Closes #94

Uses autocfg to detect the availability of the alloc crate, removing the need for a feature. This avoids forcing libraries to proxy the feature through, or awkward extra dependencies on miniz_oxide to force the feature to be enabled.

I don't actually know any way this could break semver. The no_extern_crate_alloc won't use alloc<1.36, but they're all going to be rexported in std anyway. Either way, 0.4.1 is only ~10 days old

oyvindln commented 3 years ago

Yeah this would be nice.

@HeroicKatora does this work fine for your needs?

oyvindln commented 3 years ago

Is it fine now @HeroicKatora ?