FrontEndFoxes / curriculum

Our workshop curriculum
https://frontendfoxes.github.io/curriculum/
MIT License
57 stars 76 forks source link

Setup an eslint file with linting checks in the build requirements #170

Closed MicheleCynowicz closed 2 years ago

MicheleCynowicz commented 4 years ago

Context Sometimes when contributors are writing PRs for this repo, they have default linting in their IDEs that makes more syntax changes in their PRs than we want. Let's have an eslint file in this repo that sets linting rules that will stop those default linters from changing too much code.

Expected Behavior

  1. When a contributor is running their forked copy of the app in localhost, they have a command that they can run manually to lint-check their files before committing or generating a Pull Request.

  2. When changes are made in a PR, and the Netlify build actions run, it includes linting as a requirement to pass.

Acceptance criteria

  1. I can lint my local project by running a manual lint command locally.

  2. When I push my work to origin, the CI builds are linting my work.

Additional information

Getting Started with ESLint

What build tools can do for you