search

FrontMatter / web-documentation-nextjs

Front Matter documenation
https://frontmatter.codes
25 stars 25 forks source link

Trim trailing whitespaces from documentation #25

Closed shubhusion closed 3 months ago

vercel[bot] commented 1 year ago

@shubhusion is attempting to deploy a commit to the Front Matter Team on Vercel.

A member of the Team first needs to authorize it.

shubhusion commented 1 year ago

@estruyf can you please check if this works or not. and provide authorization to vercel bot.

estruyf commented 1 year ago

Thanks, @shubhusion. It's still the same commits. Have you seen the review comments on the original PR?

image
shubhusion commented 1 year ago

Thanks, @shubhusion. It's still the same commits. Have you seen the review comments on the original PR?

image

Thanks for informing @estruyf . I guess i might have missed it.

I will make the changes soon.

shubhusion commented 1 year ago

Thanks, @shubhusion. It's still the same commits. Have you seen the review comments on the original PR?

image

@estruyf Wrapping the codeblock with <!-- markdownlint-disable-MD013 --> is not removing MD013 markdown errors. I guess the rules mentioned in .markdownlint.yaml are over-riding the default rules.

Editing the MD013 rules in .markdownlint.yaml would fix the MD013 errors in the whole repo. let me know if I can do that.

estruyf commented 1 year ago

@shubhusion markdown lint will tell you which rule IDs you need to disable. The MD013 was an example. In the code of the iframe, it should be rules: MD033 and MD013 to disable.

Example:

<!-- markdownlint-disable MD013 MD033 -->
<div class="iframe__wrapper">
   <iframe src="https://www.youtube.com/embed/0J-StFyEbV0" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen></iframe>
</div>
<!-- markdownlint-enable MD013 MD033 -->
estruyf commented 1 year ago

Btw, I have already included this in the main branch now, so that part you can skip.

shubhusion commented 1 year ago

@estruyf i have made the commits. kindly look into it.

shubhusion commented 1 year ago

@estruyf i have done the commits. let me know if there is anything left.

shubhusion commented 1 year ago

@estruyf any updates on my PR ? Is it good to go now ?

estruyf commented 12 months ago

Hi, @shubhusion, I was traveling, so I needed more time to catch up. I just checked it. Why did you add the <!-- markdownlint-disable ... --> on every file?

Your first PR was perfect; the only thing I wanted to change was the iframe, but content-wise, it was all good.

I think you misunderstood me, but turning off the lining rules on all files takes away the purpose of linting.

Would it be possible to revert it to the original PR?