search

Frontend-Hire / fh-portfolio-template

A free to use minimal portfolio template
https://portfolio.frontendhire.com/
MIT License
5 stars 7 forks source link

Add dark mode support #20

Closed NitanJana closed 1 month ago

NitanJana commented 1 month ago

Summary

This PR close #1 by adding dark mode support.

Changes Made

netlify[bot] commented 1 month ago

Deploy Preview for fh-template ready!

Name Link
Latest commit 9d2830c7fce363b54b802773f486d16ac0634dfc
Latest deploy log https://app.netlify.com/sites/fh-template/deploys/66fc399f516033000812ce88
Deploy Preview https://deploy-preview-20--fh-template.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NitanJana commented 1 month ago

Got it. Thanks for the review.

NitanJana commented 1 month ago

Also, setting the CSS variables for dark mode can be done in a cleaner way.

Could you please elaborate on how I may improve this?

yaralahruthik commented 1 month ago

Also, setting the CSS variables for dark mode can be done in a cleaner way.

Could you please elaborate on how I may improve this?

I like this approach for Tailwind https://ui.shadcn.com/docs/installation/manual