FrontendMasters / android-issues

Repository for managing publicly reported issues with the Frontend Masters Android App
https://play.google.com/store/apps/details?id=in.mjg.frontendmasters.store
6 stars 2 forks source link

Double tap to forward/rewind #28

Open dachev opened 4 years ago

nbogie commented 3 years ago

+1 to this. It's really difficult on a phone to rewind a little. The scrub bar at the bottom is very small and very inaccurate - where you might want to go back just 10 seconds you may end up being taken back many minutes, depending on the length of the section currently playing, and how fat your fingers are.

A "back-ten-seconds" button would also be ok but the UI is already overly small on phones so it'd be fiddly to use (Rewind is the second most common operation I'd make use of. Number one is simply pausing to take notes.)

dachev commented 3 years ago

Hi @nbogie. There should be skip/rewind buttons in the player controls. Do you see those on your phone? See the attached screenshot for reference.

Screenshot_2021-01-07-13-29-20-59

paragkatoch commented 3 years ago

@dachev yeah it is there, but sometimes while clicking those I often click the buttons around them, which results in video change and when I come back to the video, then its starts from starting rather than where I left off.

nbogie commented 3 years ago

Hi, @dachev, yes, I see those and they'll do, thanks - not sure how I (presumably) missed them back in Jan!

dachev commented 3 months ago

@kristakoch 1.32.0 (538)

dachev commented 3 months ago

@kristakoch 1.32.0 (539)

kristakoch commented 2 months ago

@dachev, Downloaded the latest staging app. Working well for me!

It would be nice if there was a label under the arrows telling you how far and back you're going like the YouTube player does so you'd know it was a 10 second jump without needing to check the video timecode. Especially since you can skip without the video timecode being visible.

Side note: at first I expected that if I double tapped and kept my finger held down on the screen the video would play at 2x speed forward or back. Would be a nice addition, but seems like a separate feature.

dachev commented 2 months ago

@kristakoch 1.32.0 (540)

kristakoch commented 2 months ago

@dachev The 10sec label is helpful, and the skip is still working well! One more nice thing would be if you could see the video progress bar as you skip so you know how far into the video you've made it (I feel like when I use this feature I'll often do more than 1 skip to get to a specific part of the video).

dachev commented 2 months ago

@kristakoch Displaying the video progress alone will be challenging, and including other player controls like play/pause could unfortunately lead to a visual clash with the flashing skip indicators, which we want to avoid.