SP_PLAYLIST_TYPE_PLACEHOLDER can be treated exactly like a SP_PLAYLIST_TYPE_END_FOLDER

FrontierPsychiatrist / node-spotify

A module for node.js to use libspotify.

MIT License

142 stars 20 forks source link

SP_PLAYLIST_TYPE_PLACEHOLDER can be treated exactly like a SP_PLAYLIST_TYPE_END_FOLDER #63

Closed nzoschke closed 10 years ago

nzoschke commented 10 years ago

I am not sure about the testing strategy for node-spotify, I've been making integration tests against a real account. I have been able to reproduce the orphaned placeholder and segfault quite easily by creating a folder and just deleting the folder start element.

This patch has allowed me to clean up the orphaned placeholder no problem.

FrontierPsychiatrist commented 10 years ago

Yeah, that seems like a pretty good solution.

One thing, could you add the constant SP_PLAYLIST_TYPE_PLACEHOLDER to the method NodeSpotify::getConstants for this pull request?

FrontierPsychiatrist commented 10 years ago

Merged in e4071ebd71178bb905c40b7956cb7e7bad480e59. Thanks a lot!

Somehow managed to get comments into the commit message, shouldn't do this before my first coffee on sundays.