search

Frontify / fondue

Design System of Frontify
https://fondue-components.frontify.com/
20 stars 4 forks source link

ActionMenu z-index #1144

Open robinscholz opened 1 year ago

robinscholz commented 1 year ago

It seems like the z-index of the Action Menu should be bumped up to avoid collision with other elements. Attached two screenshots of a component we are currently building.

Both the AssetInput actions as well as the LinkChooser actions have a z-index of 20. This needs to be higher in my opinion.

Screenshot 2023-01-10 at 11 33 54 Screenshot 2023-01-10 at 11 33 59

imoutaharik commented 1 year ago

Hello Robin! Thanks for using Fondue and for the feedback. I'll fix this issue as soon as possible. 😄

dominiquemb commented 1 year ago

Hi @robinscholz, I spent some time trying to reproduce this issue, and it seems like the z-index problem is coming from the container and not the AssetInput or LinkChooser components.

For example, if the container's z-index is too low, the AssetInput menu will appear to render behind any elements below it, even if the AssetInput has a z-index that is extremely high.

Is the container in which you've placed the AssetInput a custom component or is it a Fondue component? It looks custom-made.

robinscholz commented 1 year ago

The bug occurs when using the fondue components inside custom components built around the Brand-SDK. In this particular case, it is a custom component which is then used inside the Orderable List component.