Frontify / fondue

Design System of Frontify
https://fondue-components.frontify.com/
20 stars 4 forks source link

fix(Flyout): margin top is overriden #2013

Closed fulopdaniel closed 1 month ago

fulopdaniel commented 1 month ago

I was trying to fix this issue in https://github.com/Frontify/web-app/pull/5078 which got reverted, so this is the other approach.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: c4e5704d4cadb2cfb17b7b37a0b02051c81ccf66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | --------------------------- | ----- | | @frontify/fondue-components | Patch | | @frontify/fondue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-08-16 13:02 UTC

SamuelAlev commented 1 month ago

Will be fixed in https://github.com/Frontify/fondue/pull/2015, can I close the PR?

fulopdaniel commented 1 month ago

Will be fixed in #2015, can I close the PR?

great, thanks! Closed.

github-actions[bot] commented 1 month ago

Lead time: 4 hours, 43 minutes, 24 seconds (4.72 total hours) from first commit to close. Review time: 4 hours, 42 minutes, 34 seconds (4.71 total hours) from ready for review to close.