search

Frontrider / thaumic_arcana

A thaumcraft addon
5 stars 6 forks source link

Thaumcraft api on GitHub causes mod compilation to fail #11

Closed enderger closed 6 years ago

enderger commented 6 years ago

When I made my JAR file, I encountered an issue with the thaumcraft api files, the thaumcraftapi.java file to be precise. The comments that Azanor left in the file are shifted onto new lines and loose their status as comments. I believe that copying the contents of the current thaumcraftapi class into the class in the repository could fix this issue.

Frontrider commented 6 years ago

I found the issue, the API is encoded to work only on windows (the line endings are wrong), I'll run a converter on it, and it'll be fine.

Frontrider commented 6 years ago

*when I get there, hopefully tomorrow.

enderger commented 6 years ago

It seems isolated to the one class

Frontrider commented 6 years ago

I think I saw more. I'll look into it.

enderger commented 6 years ago

It did not error when I compiled the jar on Linux on any file other than the api. I remember that one of the golem-related files was missing when I compiled the jar.

Frontrider commented 6 years ago

Yeah, first I got the API from the repo, and it was missing.

than I downloaded it from the minecraft forum thread, and it was working.

Frontrider commented 6 years ago

Found the issue, I ran a code formatter on it before committing, and it broke the api.

enderger commented 6 years ago

Is this fixed?

Frontrider commented 6 years ago

Yes, as long as no formatters are run on those files.