Frontrider / thaumic_arcana

A thaumcraft addon
5 stars 6 forks source link

0.1.0 #18

Closed Frontrider closed 6 years ago

Frontrider commented 6 years ago

Now with the unexpected refactor, I'm expecting to update today or tomorrow, than curseforge takes a look at it. (to see that it's indeed not malware)

https://minecraft.curseforge.com/projects/thaumic-arcana

enderger commented 6 years ago

Once everything is released, I’ll update my fork and re-spellcheck the lang for 0.1.1, since I would like to help keep the mod as good as possible, and doing it on the minor update’s first bugfix release will make it not take hours to check over(even now, the lang file is lengthy and will grow considerably as more is added to the mod), as I will be able to skim the parts that I have checked already. Besides, I still am waiting for an excuse to fix one error that I missed.

Frontrider commented 6 years ago

Well, I guess you already did something to the mechanics: I did made an another powder after all. 2018-08-12_19 00 39

There are definitely some inconsistencies/bugs, I'll make a list of what i know about.

The lang file and the research json definitely needs some cleanup (also awaiting suggestions there)

Frontrider commented 6 years ago

I have some trouble with the build (been going for more than an hour). Looking into possible solutions.

enderger commented 6 years ago

Ill make a jar and send it to you

I have beefy hardware, so it may fix the issue

enderger commented 6 years ago

The api is still broke in the project

Frontrider commented 6 years ago

I'm moving on to CI-CD (Contious integration and deployment), and check your branch. 0.1.0 is being merged into main right now.

wamc2017 commented 6 years ago

The 0.1.0-release branch compiles fine for me if makeObfSourceJar is set to false in the build.gradle and the modid is added to gradle.properties, maybe that helps with your issues. :)

Frontrider commented 6 years ago

branch merged. and no, it's just taking a while to do the obfuscation steps..

Frontrider commented 6 years ago

Doing CI-CD setup right now, in the meantime, you can hook me up with jar until I get it ready. I'm so exited.

Pushing the changelog, than it should be deployed to curseforge.

Frontrider commented 6 years ago

my goodness, the CI build is actually showing up for merge requests.

Frontrider commented 6 years ago

We'll see it tomorrow, I might have some issues in my buildscript.

enderger commented 6 years ago

Yeah, I can’t build the mod. However, I have re-checked the lang file. Have no idea how the research.json works, though

enderger commented 6 years ago

Anyhow, just found an issue in the build.gradle. will add to the spellcheck pull request

enderger commented 6 years ago

I have compiled a jar for release and made a functional build.gradle(for my custom jar, I removed cursegradle, but left it in for the version in the pull request).

enderger commented 6 years ago

As for the obfuscation steps taking a while, I think that they are broke, as I am experiencing freezes on the exact same step. Debug input freezes, making me think that an error is causing a failure. Compiling from command line.

Frontrider commented 6 years ago

Works, the ci server failed on the publish step. Now I see why we have a "setupCiWorkspace" task.

I'll do something with the cursegradle task, currently it uses enviroment variables to hide my informations.

Frontrider commented 6 years ago

I can't access the existing build while I'm at work, I'll upload that as soon as I can.

enderger commented 6 years ago

The file that I made works, just does not use cursegradle. Anyways, the created jar comes as modid1.0.jar in the original script. Fixed in my buildfile.

Frontrider commented 6 years ago

those were stored in my gradle.properties (where they actually belong) that had sensible information in it at the time than it got messed up while merging.

enderger commented 6 years ago

The same thing happened when compiling my earlier jar.

Frontrider commented 6 years ago

I'll do it when I get there.

Frontrider commented 6 years ago

published, and I'm going to be busy the next few days.

Frontrider commented 6 years ago

Now that the jar is out, I'm closing it.