search

Frontrider / thaumic_arcana

A thaumcraft addon
5 stars 6 forks source link

Missing language key #29

Closed enderger closed 6 years ago

enderger commented 6 years ago

thaumic_arcana.wheat.stage.5 is missing in the lang file, causing a malfunctional research. Either that or it is marked as thaumic_arcana.wheat.stage.6.

enderger commented 6 years ago

Make that 2! The advanced creature enchanter research also is missing stage 3's text

Frontrider commented 6 years ago

Fixed, will push before the weekend, so you can take a look. Trying to save up on my builds for now, than we'll see where it goes. (When I push, the ci server will run all the tests, and use a build)

Frontrider commented 6 years ago

Probably extensive, but I will write a test that will scan for empty language keys and typos.

enderger commented 6 years ago

In aspects.java, the bottom of the file contains an exhaustive list of all Thaumcraft aspects.

Frontrider commented 6 years ago

It would be nearly impossible to use the API whitout that, and I challange you to look up All the places where an aspect is, and check the amount of time it takes, to copy and paste them one by one. Also, just look through the code and check where I reference those fields.

As I said, I wrote a test, that checks if the aspects are indeed valid.

enderger commented 6 years ago

There is a copy of every aspects initialization code at the bottom of aspects.java.

Frontrider commented 6 years ago

That is not a copy. That is the initialization code.

Frontrider commented 6 years ago

What I said is: I can prototype faster by not checking back and forth between several files. The problem will be solved by the automatic tests, that will fail, if something is not correct.