search

Frontrider / thaumic_arcana

A thaumcraft addon
5 stars 6 forks source link

Invalid data in research files #47

Closed Frontrider closed 6 years ago

Frontrider commented 6 years ago

I found that I can't load the research entries, currently scanning them for invalid data.

enderger commented 6 years ago

This may be the cause of the /tc research all crash.

enderger commented 6 years ago

Which entries are not loading

Frontrider commented 6 years ago

Is that a known issue?

enderger commented 6 years ago

It is marked as such in the changelog of the 1.2.0-dev branch

Frontrider commented 6 years ago

Known for thaumcraft?

Frontrider commented 6 years ago

I wrote that into the changelog, and I'm still debugging it.

wamc2017 commented 6 years ago

https://github.com/Frontrider/thaumic_arcana/blob/45348e2893ebad7f4fe49170f943df315f698182/src/main/resources/assets/thaumic_arcana/research/biomancy.json#L1053-L1055

I think that's the problem. Looks like the research requires itself and loops to death...

Frontrider commented 6 years ago

I see, can't try it now, but that should be it.

Frontrider commented 6 years ago

That was it, thanks @wamc2017.

Frontrider commented 6 years ago

today or tomorrow is 0.2.1.

enderger commented 6 years ago

How is 0.2.1 coming along

Frontrider commented 6 years ago

got to my hotel now, I have no time to build and upload. The code is on the master branch now.

It's already past midnight, and I will need my sleep for today.

enderger commented 6 years ago

Can I compile and send you the resulting jar? I can edit the build.gradle to make it not upload.

Frontrider commented 6 years ago

Thanks for the enthusiasm tough :).(status is on discord)

I might end up fully adding my new toy while I can't upload.

Frontrider commented 6 years ago

You are the kind of person, who makes it worth doing.