Frontrider / thaumic_arcana

A thaumcraft addon
5 stars 6 forks source link

Missing textures/language keys. #7

Closed enderger closed 6 years ago

enderger commented 6 years ago

Ok, so I know that issues should be 1 per thread, but I think that it would be easier for both of us if I send bug reports to you as I test since you probably would not want to scroll through issues as I report them. I feel that that would get confusing quickly.

With that out of the way, I have found 2 missing textures(Raw Relief and Plant Balls) and 1 missing name(item.plant_ball.name).

I will revise the lang file again with my findings. A few researches have unlocalised names. I will edit my fork to fix these issues and make a new pull request.

Frontrider commented 6 years ago

I know about the missing textures, I'll have to make them.

Raw relief was an item that i intended to use for a potion, but I ended up using warp ward for the task.

enderger commented 6 years ago

Also, when I edited the lang file, I found that the tree research was not existent at all, nor is there anywhere that tells users how to perform creature enchantments. There is also still no research for the self-enchantment

enderger commented 6 years ago

The recipe tabs for the creature enchantment research are very messed up.

Frontrider commented 6 years ago

No proper internet for a few days, I'll note when it's fixed in dev.

Frontrider commented 6 years ago

fixed in dev:

current todo:

What do you mean by messed up?

Frontrider commented 6 years ago

I'll also have to figure out a way to modularize my code in a way, that I can some unit testing (now that I know what I'm doing).

enderger commented 6 years ago

By messed up, I mean that the recipe for each book shows the recipe for the book above it when you click on it. By the way, if the milestone is what I think it is, I believe this should be closer to 0.5 because of the bugs being found before the jar was officially released by you.

enderger commented 6 years ago

I can send you my jar if you want. We would have to get a private connection to prevent leaks from happening due to credit issues.

enderger commented 6 years ago

I can confirm that the majority of popular thaumcraft addons work without issue with this addon.

Frontrider commented 6 years ago

I expected that, since I don't do any hacking. I only interact with thaumcraft via it's API, the rest is strictly what forge provides.

I'm fairly confident in saying, that if a mod along it breaks, than it's most likely their fault.

enderger commented 6 years ago

I will send a link to a short video showing the recipie bug.

Frontrider commented 6 years ago

Do it, last time I checked it looked fine. I know that there is an insane recipe for the strength book, since that is like 3 enchantments in one.

Might remove the research, and think about it. I'll see onto that. back to topic.

enderger commented 6 years ago

Did you look in the recipies shown in the thaumonomicon? The fertility enchant should not show anything when you click on it, but the book below it will show its recipe.

Frontrider commented 6 years ago

The recipe for the "empty" enchanted book is broken, if that is what you mean.

enderger commented 6 years ago

No, and unless you’ve updated the mod files themselves since I made my jar file, the bug still exists.

enderger commented 6 years ago

Another possibility is a discrepancy between the deobf and compiled code.

enderger commented 6 years ago

I can’t test the features that are not on GitHub yet, so it may have been fixed already.

Frontrider commented 6 years ago

I see, I guess I broke it along the way.

Frontrider commented 6 years ago

In the book, all recipes shifted downwards by one, and they require the wrong book (it's supposed to be the one before it) to be crafted with.

enderger commented 6 years ago

That's the one!

Frontrider commented 6 years ago

I wanted to do a refactor, to make this more modular, but I wanted to do that after I kicked it out. doing it now, since it will fix this kind of issue permanently.

Doing it for the plant ball now, it also had a similar problem.

Frontrider commented 6 years ago

And a general rule of thumb: The description "something is wrong" is never enough, describe the entire problem, with as many details as possible.

Frontrider commented 6 years ago

Also different issue :P, but I'm too lazy to move everything there #16

enderger commented 6 years ago

I had trouble wording the issue

Frontrider commented 6 years ago

The original is fixed, closing it and calling it done.