Open reisrobson opened 3 years ago
Oh, I agree with this one! It would be very helpful, because often times seeing the word is important to understanding the content.
Actually, I wish that I could easily disable the word replacement function altogether ... while still keeping the little "swear counter" on the app. I use the app just to make sure that there are no obscenities on a page that I'm linking for work purposes, but I don't mind seeing the words myself.
Is there an easy way to disable the word replacement/censoring while keeping other functions?
Thanks for the suggestion @reisrobson. this is actually something that I've looked into before a bit. Unfortunately the extension isn't really built for this 2-way filtering, and right now it doesn't have any "undo" functionality. The biggest challenge I see with it is that there are several different types of text that can get filtered, and not all of them would support an action like clicking above to display it. But, I do think that we could just skip those harder edge cases for now and test something that works on just regular text.
@andyknny The functionality to disable the filtering part isn't there right now, but it could be added pretty easily I think. I'll give it a try soon and let you know if I run into any other questions.
Thanks, Richard -- I really appreciate what you've created!
On Sun, Aug 22, 2021 at 2:45 PM Richard Frost @.***> wrote:
Thanks for the suggestion @reisrobson https://github.com/reisrobson. this is actually something that I've looked into before a bit. Unfortunately the extension isn't really built for this 2-way filtering, and right now it doesn't have any "undo" functionality. The biggest challenge I see with it is that there are several different types of text that can get filtered, and not all of them would support an action like clicking above to display it. But, I do think that we could just skip those harder edge cases for now and test something that works on just regular text.
@andyknny https://github.com/andyknny The functionality to disable the filtering part isn't there right now, but it could be added pretty easily I think. I'll give it a try soon and let you know if I run into any other questions.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/318#issuecomment-903327902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNMVHZKCSL5PO24LRBIVBTT6FOXBANCNFSM5AJYTJWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
@andyknny I started working on the request you made to provide a way to keep track of words filtered but not actually filter the words, and I've run into an issue. The counts are way off. Is that an issue for you?
Basically, the problem is that the filter watches for changes to the page, and each time there is a change that item gets filtered, but since the text isn't actually filtered the count increases each time that element gets updated. An example page I use for testing Commit Logs From Last Night ends up with 45 filtered words when filtering is enabled, but when I turn filtering off it counts to 353.
I can't really think of a good way around it that will still make the count meaningful. Maybe its best to just disable the counter when not filtering? Just report the words found on a particular page, and not how many times each is found?
Hi Richard, thank you kindly for giving some thought to my issue. For my purposes, I don't think the particular word count is important -- I just need to be able to spot and review any obscenity. I'm basically using it as a curseword detector. You've made a useful tool!
(BTW, my workaround has been to make up my own amusing replacements in the replacement mode. Sometimes I forget I've done that and start wondering why everyone on the internet is using the same bizarre words...)
On Fri, Aug 27, 2021 at 10:53 PM Richard Frost @.***> wrote:
@andyknny https://github.com/andyknny I started working on the request you made to provide a way to keep track of words filtered but not actually filter the words, and I've run into an issue. The counts are way off. Is that an issue for you?
Basically, the problem is that the filter watches for changes to the page, and each time there is a change that item gets filtered, but since the text isn't actually filtered the count increases each time that element gets updated. An example page I use for testing Commit Logs From Last Night http://www.commitlogsfromlastnight.com/ ends up with 45 filtered words when filtering is enabled, but when I turn filtering off it counts to 353.
I can't really think of a good way around it that will still make the count meaningful. Maybe its best to just disable the counter when not filtering? Just report the words found on a particular page, and not how many times each is found?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/318#issuecomment-907569754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNMVH6PLNUM34DKIXX4B6TT7BTUXANCNFSM5AJYTJWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
@andyknny I've moved your request to this new issue: #333
We'll keep this issue around for the request on revealing filtered words without reloading the page.
Hey Richard I loved your extension
I use for educational puroposes A system of site to training has a lot question and ansewers
There is a LOT of words like "WRONG" or "RIGHT" ...... "YES" or "NO" ... etc.... All this words are substituted by something like **** or #### that is so genial :)
I'd like wish you if it is possible to create some funtion that reveal the word that is hidden when I click above it of it for example? Or when I move mouse over it? At this moment reload the page the only option(I think....) in addition to be slow, it take the user out you from the exact place that he was reading........
I hope you understand me! Anything just reply me!
I wanna say a big Thanks for this incredible tool you made :) Have a nice day