FrostCo / AdvancedProfanityFilter

A browser extension to filter profanity from webpages
GNU General Public License v3.0
163 stars 26 forks source link

"Filter text" deselects active word #466

Closed CreeperPookie closed 1 year ago

CreeperPookie commented 1 year ago

:bug: Description

The main issue is that if you have a word selected and decide to click the Filter text checkbox, it unselects the word, causing you to potentially have to find it in the list again.

:twisted_rightwards_arrows: Steps To Reproduce

  1. In the wordlist, select any word.
  2. Click on Filter text (the current checkbox state doesn't matter)
  3. Current word deselects.

:heavy_check_mark: Expected behavior

Although this is a very minor issue, it should probably filter/unfilter the text in the selection, but keep the current selection.

:computer: Details

:pencil: Additional context

Although there isn't a good reason why you would click the checkbox after selecting a word, an accidental click could cause you to have to re-type a substitution for a word. Also, I believe this issue was referenced in the first comment of issue #322, although I'm not completely certain.

richardfrost commented 1 year ago

This has been included in version 2.40.0. Feel free to comment here if you have any feedback for this update.